Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add --clang-tidy-version option to ament_clang_tidy #289

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jan 20, 2021

Signed-off-by: Tyler Weaver [email protected]

This also contains some of the cleanup of the doc from the --packages-select PR. As pointed out here these are not all the changes needed to support clang-tidy-10.

@audrow audrow self-assigned this Feb 5, 2021
@audrow
Copy link
Contributor

audrow commented Feb 5, 2021

Hi @tylerjw, what's the status of this? Is there anything I can do to help move this along, like run CI?

@tylerjw
Copy link
Contributor Author

tylerjw commented Feb 6, 2021

The issue is the regular expression for parsing the output doesn't work with newer versions of clang-tidy. I haven't had a chance to try to update the regular expression yet. I think the next step is figuring that out. I specifically want to use this with clang-tidy-10 as it is what we are using on the moveit project.

@wmmc88
Copy link

wmmc88 commented Jun 9, 2021

Any chance that you're going to land this pr @tylerjw ?

@tylerjw
Copy link
Contributor Author

tylerjw commented Jun 9, 2021

I stopped working on this because we transitioned to using industrial_ci on GitHub actions for moveit and that project has a nice interface for running clang-tidy. I can put this on my list of things to do but it might be a while as we don't need this any more for the moveit project. Anyone else is welcome to take over this PR and finish it.

@nuclearsandwich
Copy link
Contributor

@wmmc88 with #316 newer versions of clang-tidy can be found however other than the search order hard-coded in the source there is no control over which available clang-tidy binary is used. https://github.com/nuclearsandwich/ament_lint/blob/6f39d0b6a5b7428d085e5a40d3c57ed7c3e88a32/ament_clang_tidy/ament_clang_tidy/main.py#L115-L118

@wmmc88
Copy link

wmmc88 commented Sep 24, 2021

@wmmc88 with #316 newer versions of clang-tidy can be found however other than the search order hard-coded in the source there is no control over which available clang-tidy binary is used. https://github.com/nuclearsandwich/ament_lint/blob/6f39d0b6a5b7428d085e5a40d3c57ed7c3e88a32/ament_clang_tidy/ament_clang_tidy/main.py#L115-L118

Nice! Are those changes backported to foxy?

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants