-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add --clang-tidy-version option to ament_clang_tidy #289
base: rolling
Are you sure you want to change the base?
Conversation
Hi @tylerjw, what's the status of this? Is there anything I can do to help move this along, like run CI? |
The issue is the regular expression for parsing the output doesn't work with newer versions of clang-tidy. I haven't had a chance to try to update the regular expression yet. I think the next step is figuring that out. I specifically want to use this with clang-tidy-10 as it is what we are using on the moveit project. |
Any chance that you're going to land this pr @tylerjw ? |
I stopped working on this because we transitioned to using industrial_ci on GitHub actions for moveit and that project has a nice interface for running clang-tidy. I can put this on my list of things to do but it might be a while as we don't need this any more for the moveit project. Anyone else is welcome to take over this PR and finish it. |
@wmmc88 with #316 newer versions of clang-tidy can be found however other than the search order hard-coded in the source there is no control over which available clang-tidy binary is used. https://github.com/nuclearsandwich/ament_lint/blob/6f39d0b6a5b7428d085e5a40d3c57ed7c3e88a32/ament_clang_tidy/ament_clang_tidy/main.py#L115-L118 |
Nice! Are those changes backported to foxy? |
Signed-off-by: Tyler Weaver [email protected]
This also contains some of the cleanup of the doc from the --packages-select PR. As pointed out here these are not all the changes needed to support clang-tidy-10.